Upgrade to Julia 1.3+, use JLL packages to provide binary dependencies#59
Merged
fhs merged 1 commit intofhs:masterfrom Nov 28, 2019
Merged
Upgrade to Julia 1.3+, use JLL packages to provide binary dependencies#59fhs merged 1 commit intofhs:masterfrom
fhs merged 1 commit intofhs:masterfrom
Conversation
Owner
|
AppVeyor Environment: julia_version=1.3; Platform: x86 is failing. I restarted the build and it's still failing. |
Contributor
Author
|
We can wait until RC5 is released; it has a bug fix that should address that issue |
|
Bump 🙂 Julia 1.3 is out, the problem with Windows i686 should have been fixed. Another CI run? |
giordano
reviewed
Nov 28, 2019
Owner
|
Build seems to pass now. Is this ready to be merged? |
|
Need to fix the |
fhs
approved these changes
Nov 28, 2019
Owner
fhs
left a comment
fhs
left a comment
There was a problem hiding this comment.
I'll fix up Project.toml after merge.
|
Cool, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a POC of eliminating BinaryProvider from your package and using the new JLL packages introduced in Julia 1.3