Merged
Conversation
Using the value returned by `pointer()` is unsafe unless Julia is told to preserve the owner of that memory. GC.@ preserve is the right way to do this. Also set the pointer fields `next_in` and `next_out` to `C_NULL` whenever we're finished with them to prevent use-after-free surprises. While not exactly necessary in an ideal bug-free world, this should help with robustness by detecting any accidental reuse of stale buffers.
This was referenced Sep 3, 2020
Contributor
Author
|
Hmm. The FreeBSD CI failures seem like a CI config problem. |
fhs
approved these changes
Sep 3, 2020
Owner
fhs
left a comment
fhs
left a comment
There was a problem hiding this comment.
Nice catch!
I think I've fixed the FreeBSD CI issue (at least for Julia 1.3).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #71
Using the value returned by
pointer()is unsafe unless Julia is toldto preserve the owner of that memory.
GC.@preserveis the right way todo this. In some cases the
GC.@preserveused here may cover aslightly larger scope than may be strictly necessary. But this should be ok,
as it's essentially free.
Also set the pointer fields
next_inandnext_outtoC_NULLwhenever we're finished with them to prevent use-after-free surprises.
While not exactly necessary in an ideal bug-free world, this should help
with robustness by detecting any accidental reuse of stale buffers.