Skip to content

Code Quality: Migrate from VSTest to Microsoft.Testing.Platform#17982

Merged
yair100 merged 5 commits intofiles-community:mainfrom
Youssef1313:mtp
Jan 20, 2026
Merged

Code Quality: Migrate from VSTest to Microsoft.Testing.Platform#17982
yair100 merged 5 commits intofiles-community:mainfrom
Youssef1313:mtp

Conversation

@Youssef1313
Copy link
Copy Markdown
Contributor

@Youssef1313 Youssef1313 commented Dec 21, 2025

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Looking at the test run in CI confirming that all tests are still running as before. (Still waiting for workflows to be approved to run)

Comment thread global.json Outdated
Copy link
Copy Markdown
Contributor

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the global.json, LGTM

@yair100 yair100 added the ready for review Pull requests that are ready for review label Dec 21, 2025
@hez2010
Copy link
Copy Markdown
Member

hez2010 commented Dec 22, 2025

Looks fine to me. Thank you!

yair100
yair100 previously approved these changes Dec 22, 2025
@yair100 yair100 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Dec 22, 2025
Comment thread .github/workflows/ci.yml Outdated
@yair100
Copy link
Copy Markdown
Member

yair100 commented Jan 6, 2026

@Youssef1313 it looks like the ci pipeline is failing.

@yair100
Copy link
Copy Markdown
Member

yair100 commented Jan 19, 2026

@Youssef1313 following up.

Signed-off-by: Youssef Victor <youssefvictor00@gmail.com>
@Youssef1313
Copy link
Copy Markdown
Contributor Author

Looks like CI logs were gone. Rebased to get a fresh build to and see what is the error.

Comment thread .github/workflows/ci.yml
Comment thread tests/Files.InteractionTests/Files.InteractionTests.csproj
Signed-off-by: Youssef Victor <youssefvictor00@gmail.com>
Comment thread .github/workflows/ci.yml
@yair100
Copy link
Copy Markdown
Member

yair100 commented Jan 20, 2026

Thank you. LGTM

@yair100 yair100 merged commit 11e2cc9 into files-community:main Jan 20, 2026
6 checks passed
@Youssef1313 Youssef1313 deleted the mtp branch January 20, 2026 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code Quality: Migrate tests from VSTest to Microsoft.Testing.Platform

5 participants