Skip to content

Compatibility Issue Detected with Python 3.11 and aws lambda#73

Merged
hemanth-3 merged 4 commits intofilestack:developfrom
amarnathcls:compatibility_issue/FS-116161
May 10, 2024
Merged

Compatibility Issue Detected with Python 3.11 and aws lambda#73
hemanth-3 merged 4 commits intofilestack:developfrom
amarnathcls:compatibility_issue/FS-116161

Conversation

@amarnathcls
Copy link
Copy Markdown
Contributor

Made below changes

  1. AS older version of pytest and pytest-cov are not supported with latest versions of python updated their versions in requirements.text file.
  2. As ThreadPool of multiprocessing library not supported by aws lambda used ThreadPoolExecutor of concurrent.futures

import threading
from urllib3.util.retry import Retry
from multiprocessing.pool import ThreadPool
# from multiprocessing.pool import ThreadPool
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove commented code

Copy link
Copy Markdown
Contributor

@sethk4783 sethk4783 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hemanth-3 hemanth-3 merged commit cb0c3d5 into filestack:develop May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants