fix: resolve brittle timezone test in TestPureDate#4533
Open
kapilhadoltikar wants to merge 1 commit intofinos:masterfrom
Open
fix: resolve brittle timezone test in TestPureDate#4533kapilhadoltikar wants to merge 1 commit intofinos:masterfrom
kapilhadoltikar wants to merge 1 commit intofinos:masterfrom
Conversation
Updated testFormatWithTimeZoneShift to accept both shorthand abbreviations (CST) and GMT offsets (GMT-06:00). Refactored repeated logic into a regex-based helper method for better maintainability. Closes Issue finos#4531 Signed-off-by: kapilh <146179927+kapilhadoltikar@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the brittle assertion failures in
TestPureDate.testFormatWithTimeZoneShiftreported in #4531.The root cause was a dependency on the JDK's default Locale Provider. In modern environments (JDK 9+ using CLDR), the
zformat specifier often resolves to a localized GMT offset (e.g.,GMT-06:00) instead of the alphanumeric abbreviation (e.g.,CST). This caused strict string equality tests to fail despite the date-time logic being correct.Changes
assertDateWithZone.Verification Results
TestPureDatenow passes successfully (15/15 tests).Related Issues
Checklist
-s)mvn clean test -Dtest=TestPureDatePureDatedomain logicTest Fail
Test Success