fix(firestore-translate-text): removed unnecessary sanitization#2574
fix(firestore-translate-text): removed unnecessary sanitization#2574JanKubicek wants to merge 4 commits intofirebase:nextfrom
Conversation
…onStart event (firebase#2562) * fix(storage-resize-images): add missing recordStartEvent call * feat(storage-resize-images): add onStorageResize event * docs(storage-resize-images): update changelog * chore(storage-resize-images): add onStartResize * chore(storage-resize-images): add onStartResize event --------- Co-authored-by: Tadej <tadej.dev@gmail.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hi, do you have an estimate for when this will be released? |
|
Hey @JanKubicek. This fix works for VertexAI, but for GoogleAI, it's only half of the problem. Unlike VertexAI, GoogleAI's seems to remove the new lines itself when dealing with structured outputs. I'm looking into a fix for this. |
|
One fix is switching from using |
|
@JanKubicek are you OK to sign the CLA so we can get this in? Thanks! |
Removes unnecessary text sanitization that caused formatting issues during translation.