fix(auth): check if user disabled on check_revoked#565
Merged
bojeil-google merged 4 commits intomasterfrom Aug 4, 2021
Merged
Conversation
When `verify_session_cookie` or `verify_id_token` is called with `check_revoked` set to `True` we should also check if the user is disabled. If disabled the `UserDisabledError` is raised.
Contributor
Author
Thanks for the quick review. we are planning to fix this in Node.js, Java and Golang too. |
Member
|
Added @egilmorez for docs changes. Thanks! |
hiranya911
suggested changes
Aug 4, 2021
Contributor
hiranya911
left a comment
hiranya911
left a comment
There was a problem hiding this comment.
Looks mostly good. Just had one suggestion about the base type for the new UserDisabledError class.
hiranya911
approved these changes
Aug 4, 2021
Contributor
hiranya911
left a comment
hiranya911
left a comment
There was a problem hiding this comment.
LGTM with a suggestion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
verify_session_cookieorverify_id_tokenis called withcheck_revokedset toTruewe should also check if the user isdisabled.
If disabled the
UserDisabledErroris raised.