Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a KSP processor for generating Firebase AI schemas, which is a fantastic addition for improving developer experience with Firebase AI. The implementation is well-structured. I've provided a few suggestions to address some minor bugs in the processor logic, improve the API design of the published artifact, and fix some minor formatting issues. Overall, great work!
firebase-ai-ksp-processor/src/main/kotlin/com/google/firebase/ai/ksp/SchemaSymbolProcessor.kt
Outdated
Show resolved
Hide resolved
firebase-ai-ksp-processor/src/main/kotlin/com/google/firebase/ai/ksp/SchemaSymbolProcessor.kt
Outdated
Show resolved
Hide resolved
firebase-ai-ksp-processor/src/main/kotlin/com/google/firebase/ai/ksp/SchemaSymbolProcessor.kt
Outdated
Show resolved
Hide resolved
firebase-ai-ksp-processor/src/main/kotlin/com/google/firebase/ai/annotations/Generable.kt
Outdated
Show resolved
Hide resolved
.../main/resources/META-INF/services/com.google.devtools.ksp.processing.SymbolProcessorProvider
Outdated
Show resolved
Hide resolved
…ai/ksp/SchemaSymbolProcessor.kt Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…ai/ksp/SchemaSymbolProcessor.kt Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…ai/annotations/Generable.kt Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Size Report 1Affected Products
Test Logs |
Coverage Report 1Affected Products
Test Logs |
|
The public api surface has changed for the subproject firebase-ai: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
firebase-ai/src/main/kotlin/com/google/firebase/ai/annotations/Generable.kt
Show resolved
Hide resolved
firebase-ai-ksp-processor/src/main/kotlin/com/google/firebase/ai/ksp/SchemaSymbolProcessor.kt
Outdated
Show resolved
Hide resolved
firebase-ai-ksp-processor/src/main/kotlin/com/google/firebase/ai/ksp/SchemaSymbolProcessor.kt
Outdated
Show resolved
Hide resolved
firebase-ai/src/main/kotlin/com/google/firebase/ai/annotations/Guide.kt
Outdated
Show resolved
Hide resolved
firebase-ai/src/main/kotlin/com/google/firebase/ai/annotations/Generable.kt
Outdated
Show resolved
Hide resolved
firebase-ai/src/main/kotlin/com/google/firebase/ai/annotations/Guide.kt
Outdated
Show resolved
Hide resolved
firebase-ai/src/main/kotlin/com/google/firebase/ai/annotations/Guide.kt
Outdated
Show resolved
Hide resolved
firebase-ai/src/main/kotlin/com/google/firebase/ai/common/APIController.kt
Show resolved
Hide resolved
firebase-ai/src/main/kotlin/com/google/firebase/ai/type/GenerateObjectResponse.kt
Outdated
Show resolved
Hide resolved
firebase-ai/src/main/kotlin/com/google/firebase/ai/type/GenerationConfig.kt
Outdated
Show resolved
Hide resolved
firebase-ai/src/main/kotlin/com/google/firebase/ai/type/JsonSchema.kt
Outdated
Show resolved
Hide resolved
firebase-ai/src/main/kotlin/com/google/firebase/ai/type/Schema.kt
Outdated
Show resolved
Hide resolved
Requested changes completed, github complaining
* Adds the `Generable` and `Guide` annotations * Adds the KSP processor to turn them into firebase AI schema objects * Adds publishing plugin to export maven repo for ADMRS --------- Co-authored-by: David Motsonashvili <davidmotson@google.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
* Adds the `Generable` and `Guide` annotations * Adds the KSP processor to turn them into firebase AI schema objects * Adds publishing plugin to export maven repo for ADMRS --------- Co-authored-by: David Motsonashvili <davidmotson@google.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
GenerableandGuideannotations