Skip to content

Add Firebase AI KSP Processor#7523

Merged
davidmotson merged 79 commits intomainfrom
davidmotson.firebase-ai-ksp-processor
Jan 29, 2026
Merged

Add Firebase AI KSP Processor#7523
davidmotson merged 79 commits intomainfrom
davidmotson.firebase-ai-ksp-processor

Conversation

@davidmotson
Copy link
Contributor

@davidmotson davidmotson commented Oct 30, 2025

  • Adds the Generable and Guide annotations
  • Adds the KSP processor to turn them into firebase AI schema objects
  • Adds publishing plugin to export maven repo for ADMRS

@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@davidmotson davidmotson requested a review from rlazo October 30, 2025 19:34
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@davidmotson
Copy link
Contributor Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a KSP processor for generating Firebase AI schemas, which is a fantastic addition for improving developer experience with Firebase AI. The implementation is well-structured. I've provided a few suggestions to address some minor bugs in the processor logic, improve the API design of the published artifact, and fix some minor formatting issues. Overall, great work!

davidmotson and others added 4 commits October 30, 2025 12:43
…ai/ksp/SchemaSymbolProcessor.kt

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…ai/ksp/SchemaSymbolProcessor.kt

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…ai/annotations/Generable.kt

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@google-oss-bot
Copy link
Collaborator

google-oss-bot commented Oct 30, 2025

Size Report 1

Affected Products

  • firebase-ai

    TypeBase (f1644ff)Merge (cf1203a)Diff
    aar1.12 MB1.16 MB+44.3 kB (+4.0%)
    apk (aggressive)1.71 MB1.74 MB+27.8 kB (+1.6%)
    apk (release)11.0 MB11.0 MB+34.7 kB (+0.3%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/3Kkurh4TnU.html

@google-oss-bot
Copy link
Collaborator

google-oss-bot commented Oct 30, 2025

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.37% (f1644ff) to 50.41% (cf1203a) by +0.04%.

    FilenameBase (f1644ff)Merge (cf1203a)Diff
    ChildChangeAccumulator.java83.33%96.67%+13.33%
  • firebase-firestore

    Overall coverage changed from 46.16% (f1644ff) to 46.16% (cf1203a) by +0.00%.

    FilenameBase (f1644ff)Merge (cf1203a)Diff
    DeleteMutation.java90.48%95.24%+4.76%
  • firebase-sessions

    Overall coverage changed from 80.97% (f1644ff) to 81.08% (cf1203a) by +0.11%.

    FilenameBase (f1644ff)Merge (cf1203a)Diff
    FirebaseSessionsComponent.kt62.07%63.79%+1.72%
  • firebase-storage

    Overall coverage changed from 84.93% (f1644ff) to 85.31% (cf1203a) by +0.38%.

    FilenameBase (f1644ff)Merge (cf1203a)Diff
    StorageException.java65.45%69.09%+3.64%
    StorageTask.java83.38%83.99%+0.60%
    UploadTask.java81.52%83.17%+1.65%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/JU0wffsU3u.html

@google-oss-bot
Copy link
Collaborator

google-oss-bot commented Oct 30, 2025

Startup Time Report 1

The report is too large (117,066 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/2lxQwsX1sk/index.html

@google-oss-bot
Copy link
Collaborator

The public api surface has changed for the subproject firebase-ai:
error: Attempted to change parameter name from prompt to inputPrompt in method com.google.firebase.ai.Chat.sendMessage [ParameterNameChange]
error: Added class com.google.firebase.ai.type.AutoFunctionDeclaration [AddedClass]
error: Added class com.google.firebase.ai.type.JsonSchema [AddedClass]
error: Removed method com.google.firebase.ai.type.Tool.functionDeclarations(java.util.List<com.google.firebase.ai.type.FunctionDeclaration>) [RemovedMethod]
error: Added method com.google.firebase.ai.type.Tool.functionDeclarations(java.util.List<com.google.firebase.ai.type.FunctionDeclaration>,java.util.List>) [AddedMethod]
error: Removed method com.google.firebase.ai.type.Tool.Companion.functionDeclarations(java.util.List<com.google.firebase.ai.type.FunctionDeclaration>) [RemovedMethod]
error: Added method com.google.firebase.ai.type.Tool.Companion.functionDeclarations(java.util.List<com.google.firebase.ai.type.FunctionDeclaration>,java.util.List>) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@davidmotson davidmotson requested a review from rlazo January 27, 2026 22:58
@davidmotson davidmotson enabled auto-merge (squash) January 29, 2026 00:24
@davidmotson davidmotson disabled auto-merge January 29, 2026 03:50
@davidmotson davidmotson enabled auto-merge (squash) January 29, 2026 19:21
@davidmotson davidmotson dismissed emilypgoogle’s stale review January 29, 2026 19:31

Requested changes completed, github complaining

@davidmotson davidmotson merged commit 338e220 into main Jan 29, 2026
316 of 328 checks passed
@davidmotson davidmotson deleted the davidmotson.firebase-ai-ksp-processor branch January 29, 2026 20:03
rlazo pushed a commit that referenced this pull request Jan 30, 2026
* Adds the `Generable` and `Guide` annotations
* Adds the KSP processor to turn them into firebase AI schema objects
* Adds publishing plugin to export maven repo for ADMRS

---------

Co-authored-by: David Motsonashvili <davidmotson@google.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
rlazo pushed a commit that referenced this pull request Jan 30, 2026
* Adds the `Generable` and `Guide` annotations
* Adds the KSP processor to turn them into firebase AI schema objects
* Adds publishing plugin to export maven repo for ADMRS

---------

Co-authored-by: David Motsonashvili <davidmotson@google.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants