snapshot listeners source from cache#7982
Conversation
🦋 Changeset detectedLatest commit: a340dd6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (203,112 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
Changeset File Check ✅
|
packages/firestore/test/integration/api/snasphot_listener_source.test.ts
Show resolved
Hide resolved
wu-hui
left a comment
There was a problem hiding this comment.
Another round. I am half way through tests, but I think we should try to make our tests cover different query/collection combinations.
packages/firestore/test/integration/api/snasphot_listener_source.test.ts
Outdated
Show resolved
Hide resolved
packages/firestore/test/integration/api/snasphot_listener_source.test.ts
Show resolved
Hide resolved
packages/firestore/test/integration/api/snasphot_listener_source.test.ts
Show resolved
Hide resolved
packages/firestore/test/integration/api/snasphot_listener_source.test.ts
Show resolved
Hide resolved
packages/firestore/test/integration/api/snasphot_listener_source.test.ts
Outdated
Show resolved
Hide resolved
wu-hui
left a comment
There was a problem hiding this comment.
I am very happy with the thorough test coverage.
There is a comment about SnapshotInSync though, which I think is behavior is not expected. Can you investigate?
Other than this one, it should be good to go.
wu-hui
left a comment
There was a problem hiding this comment.
LGTM, really good work, and sets an example of the test coverage we should be aiming for.
Thanks for your patience to address my feedbacks and questions.
egilmorez
left a comment
There was a problem hiding this comment.
Seconding Mark's approval, thanks!
|
@markarndt The public interface |
Adding
ListenSourceenum toSnapshotListenOptions.tests include integration tests and spec tests on: