Repository navigation
fix(fork): merge upstream b23f94e into patch/sqlite-reader-pool - #263
Merged
fireboltdude1357 merged 213 commits intoNov 13, 2026
Merged
fireboltdude1357 merged 213 commits into
fireboltdude1357 merged 213 commits into
Conversation
…on box (pingdotgg#32682) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Yash Singh <saiansh2525@gmail.com>
…35565) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…pingdotgg#35563) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ingdotgg#32302) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…pingdotgg#35322) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ping each key (pingdotgg#35581) Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
…card (pingdotgg#31115) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: Yash Singh <saiansh2525@gmail.com>
…t pull (pingdotgg#26568) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ingdotgg#35586) Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
…after a full scan (pingdotgg#33993) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ls (pingdotgg#27928) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…rrow viewports (pingdotgg#29288) Co-authored-by: imluckii <imluckii@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…1723) Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com> Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
…in worktrees (pingdotgg#33923) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…its for its status read (pingdotgg#33877) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…r (median 7,826 to 3,168 ms) (pingdotgg#33954) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…otgg#33858) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ingdotgg#33902) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ly (pingdotgg#33896) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…worktrees (pingdotgg#33908) Co-authored-by: Julius Marminge <julius0216@outlook.com>
… pass (pingdotgg#26935) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ingdotgg#35783) * feat(mobile): secret field gets an eye toggle to show what you typed
…t frame (pingdotgg#35683) Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…us (pingdotgg#23141) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…#29452) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ingdotgg#33782) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…p tabs (pingdotgg#32854) Co-authored-by: Julius Marminge <julius0216@outlook.com>
# Conflicts: # packages/shared/src/nodeSqliteClient.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fork's nightly build fails because
patch/sqlite-reader-poolconflicts with upstream b23f94e inpackages/shared/src/nodeSqliteClient.ts(6 hunks).Upstream pingdotgg#35728 moves the writer onto a worker thread and rewrites the file around a shared
makeWorkerConnection. It still routes reads by claim count over 4 readers, each with its ownSemaphore(1), so a new read can overtake one that is already waiting.I kept upstream's
makeWorkerConnection,makeReader, writer worker, checkpoint worker andREADER_POOL_SIZEexactly as they are. The patch's ordered pool is back asmakeReaderPool(filename), built over upstream'smakeReader:route's reader branch now leases a slot from that pool and falls back to upstream'swriter. Readers no longer take a per-reader lock, because the slot already gives them the connection alone.db.lock_wait_msfor a reader counts the time spent waiting for a slot.nodeSqliteClient.test.tspasses, with 27 tests including the patch's 4 pool tests. pingdotgg#35728'sSqlite.test.ts,FoundationPersistence.test.tsandProjectService.test.tspass too.On a scratch stack of upstream b23f94e with all 26 patches and this branch,
pnpm install --no-frozen-lockfile,vp run typecheck(41 of 41) andvp test runon the test files the patches touch, plus those upstream tests, all pass (51 files, 1439 tests).Made by Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code