Skip to content

Comments

feat: log individual download times during parsing#1767

Merged
firecow merged 2 commits intomasterfrom
feat/download-logging
Feb 18, 2026
Merged

feat: log individual download times during parsing#1767
firecow merged 2 commits intomasterfrom
feat/download-logging

Conversation

@firecow
Copy link
Owner

@firecow firecow commented Feb 18, 2026

Summary

  • Print a line for each download (remote include, project file, component, remote variables) showing what was fetched and how long it took
  • Only logs when an actual download happens (skips cached files)

Example output:

downloaded https://gitlab.com/org/project/-/raw/main/.ci.yml in 312ms
downloaded my-group/my-project HEAD .gitlab-ci.yml in 1.2s
downloaded git@gitlab.com:org/vars.git main variables.yml in 891ms
parsing and downloads finished in 1.5s.

Closes #1759


Summary by cubic

Add per-download timing logs during parsing to help spot slow downloads; cached files are skipped.
Also refactors the download helpers to use a single opts object to reduce parameters.

Written for commit 6651c2b. Summary will update on new commits.

Print a line for each remote include, project file, component, and
remote variables download showing what was fetched and how long it took.
This helps users identify which downloads are slow.

Closes #1759
@firecow firecow self-assigned this Feb 18, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@firecow firecow requested a review from LauJosefsen February 18, 2026 08:49
@firecow
Copy link
Owner Author

firecow commented Feb 18, 2026

@LauJosefsen Its not easy to time "parsing" on its own. But the individual downloads timed along with the total time will definently give us a better picture of what is taking time.

…count

Fixes SonarCloud "too many parameters" issue on downloadIncludeProjectFile
and downloadIncludeComponent by passing ParserIncludesInitOptions instead
of individual cwd, stateDir, gitData, fetchIncludes, writeStreams params.
@sonarqubecloud
Copy link

@firecow firecow merged commit ceed5fb into master Feb 18, 2026
12 checks passed
@firecow firecow deleted the feat/download-logging branch February 18, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cache remote downloads and .gitlab-ci.yml

2 participants