Skip to content

backend: migrate go-bindata to embed#1132

Merged
tormath1 merged 1 commit intoflatcar:mainfrom
tylerauerbeck:bindata-to-embed
Jul 16, 2025
Merged

backend: migrate go-bindata to embed#1132
tormath1 merged 1 commit intoflatcar:mainfrom
tylerauerbeck:bindata-to-embed

Conversation

@tylerauerbeck
Copy link
Contributor

Migrate from go-bindata to embed

This migrates the usage of go-bindata to use the native functionality provided by embed. This will allow us to clean up an unmaintained dependency and ultimately appears to make the functionality provided a bit easier to understand.

How to use

With a running empty database

docker run --name nebraska -e POSTGRES_USER=postgres -e POSTGRES_PASSWORD=nebraska -e POSTGRES_DB=nebraska -p 5432:5432 -d postgres
  • Run make run-backend
  • Confirm database tables appear as expected

Testing done

This was tested manually as mentioned above. I also made sure to run make ci to ensure that all existing tests pass as expected.

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

resolves #1122

@tylerauerbeck
Copy link
Contributor Author

I just added the necessary code to the existing pkg/api/api.go, but if this makes more sense to split out let me know and we can clean that up. Functionally though, this appears to be passing the sniff test and existing set of tests that I'd expect.

@tylerauerbeck tylerauerbeck force-pushed the bindata-to-embed branch 2 times, most recently from 929a395 to 4068672 Compare July 16, 2025 02:56
Signed-off-by: Tyler Auerbeck <tylerauerbeck@users.noreply.github.com>
@tormath1 tormath1 merged commit be18aa1 into flatcar:main Jul 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace go-bindata with embed

2 participants