backend: migrate go-bindata to embed#1132
Merged
tormath1 merged 1 commit intoflatcar:mainfrom Jul 16, 2025
Merged
Conversation
Contributor
Author
|
I just added the necessary code to the existing |
tormath1
reviewed
Jul 7, 2025
929a395 to
4068672
Compare
Signed-off-by: Tyler Auerbeck <tylerauerbeck@users.noreply.github.com>
4068672 to
e5dc59a
Compare
tormath1
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate from go-bindata to embed
This migrates the usage of
go-bindatato use the native functionality provided byembed. This will allow us to clean up an unmaintained dependency and ultimately appears to make the functionality provided a bit easier to understand.How to use
With a running empty database
make run-backendTesting done
This was tested manually as mentioned above. I also made sure to run
make cito ensure that all existing tests pass as expected.changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.resolves #1122