Skip to content

feat: --estimate flag on issues create and issues update#91

Merged
flipbit03 merged 4 commits intoflipbit03:mainfrom
lightstrikelabs:feat/issues-estimate-flag
Mar 6, 2026
Merged

feat: --estimate flag on issues create and issues update#91
flipbit03 merged 4 commits intoflipbit03:mainfrom
lightstrikelabs:feat/issues-estimate-flag

Conversation

@lightstrike
Copy link
Copy Markdown
Contributor

Summary

  • Add --estimate / -e flag to issues create and issues update commands
  • Wire estimate into IssueCreateInput and IssueUpdateInput
  • Update no-op guard on issues update to include --estimate
  • Add [-e N] to lineark usage for both commands
  • Add 3 offline tests for estimate flag visibility and error messages

Test plan

  • cargo clippy --workspace -- -D warnings clean
  • cargo fmt --check clean
  • cargo test --workspace — 67 offline tests pass (3 new)
  • Smoke test: lineark issues create "Test" --team ENG --estimate 3
  • Smoke test: lineark issues update ENG-xxx --estimate 5

@flipbit03 flipbit03 added the safe-to-test Maintainer-approved: run online tests with API secrets label Feb 24, 2026
@github-actions github-actions bot removed the safe-to-test Maintainer-approved: run online tests with API secrets label Feb 24, 2026
@flipbit03
Copy link
Copy Markdown
Owner

@lightstrike column alignment needs to be fixed in some places. usage.rs column alignment is broken. I've had this issue happen so many times in Claude Code-assisted development that I've simply created a linter for it 😁 It should be trivial to fix. Thanks!

@lightstrike lightstrike force-pushed the feat/issues-estimate-flag branch from 39ae365 to 6f9d002 Compare February 28, 2026 20:18
@lightstrike
Copy link
Copy Markdown
Contributor Author

@flipbit03 Ready for review again — rebased onto main and fixed the column alignment in usage.rs. All CI checks passing.

@flipbit03 flipbit03 force-pushed the feat/issues-estimate-flag branch from 6f9d002 to 17a66e5 Compare March 6, 2026 18:01
Add estimate to IssueDetail so it appears in `issues read` JSON
and human output. Without this, setting --estimate on create/update
had no way to be verified via the CLI.
@flipbit03
Copy link
Copy Markdown
Owner

Hey @lightstrike — I rebased onto the latest main (which now includes PR #88), resolved the conflicts, and pushed. I also made a few improvements:

Fixes applied:

  • Unique test names: The online test for estimate used a hardcoded "[test] CLI estimate flag" name — changed it to use a UUID suffix to avoid conflicts from zombie resources (same fix we applied across all tests in feat: --project filter on issues list #88)
  • Proper error handling: Added output.status.success() checks with stdout/stderr in assertion messages before parsing JSON, so failures show the actual error instead of cryptic parse errors
  • Added estimate to issues read output: The PR wired --estimate into create/update, but the IssueDetail type used by issues read didn't include the field — so there was no way to verify the estimate via CLI after setting it. Added it so issues read now shows "estimate": 3.0.

Smoke tests confirmed:

  • lineark issues create "test" --team CAD -e 3 → creates with estimate 3
  • lineark issues read CAD-xxx → shows "estimate": 3.0
  • lineark issues update CAD-xxx -e 5 → read confirms "estimate": 5.0
  • Both -e short flag and --estimate long flag work

Follow-up issue: While reviewing the output, we noticed priority is output as both a raw number ("priority": 0.0) and a label ("priorityLabel": "No priority"), which is redundant and confusing. Carved out #116 to clean that up separately.

All 51 online tests passing. Ready to merge!

@flipbit03 flipbit03 added the safe-to-test Maintainer-approved: run online tests with API secrets label Mar 6, 2026
@github-actions github-actions bot removed the safe-to-test Maintainer-approved: run online tests with API secrets label Mar 6, 2026
Copy link
Copy Markdown
Owner

@flipbit03 flipbit03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's gooooooo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants