feat(oidc): support configurable token signing algorithms#5362
feat(oidc): support configurable token signing algorithms#5362markphelps merged 1 commit intoflipt-io:v2from
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2 #5362 +/- ##
==========================================
+ Coverage 59.97% 60.54% +0.56%
==========================================
Files 138 138
Lines 13578 13584 +6
==========================================
+ Hits 8144 8225 +81
+ Misses 4735 4662 -73
+ Partials 699 697 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@gzxu thank you for the PR. |
|
Thanks @erka for reviewing! Quick question: Which command can I use to auto-generate |
|
You have to do it manually. Cue didn't support it in the past. You could ask llm to do it as alternative. They usually do a good job in this case. |
|
Ah you're right, LLM did a good job. Thanks! |
Some OIDC providers sign ID tokens with non-RS256 algorithms. Add an `algorithms` setting to the OIDC provider config and plumb it through to the OIDC client configuration. Default remains ["RS256"] for backward compatibility. Signed-off-by: Edward Xu <[email protected]>
markphelps
left a comment
There was a problem hiding this comment.
looks great! ty for your contribution @gzxu !!
Summary
Add an
algorithmsfield to the OIDC provider configuration so Flipt can verify ID tokens signed with algorithms other than RS256.closes #5361.
Changes
authentication.methods.oidc.providers.<provider>.algorithms(default["RS256"])Test plan