Cherry-pick commits from researchgate upstream#15
Merged
tPl0ch merged 2 commits intoflix-tech:masterfrom Aug 23, 2021
Merged
Conversation
As seen [here](https://github.com/researchgate/avro-php/blob/ff8841585ad76acbff5b673bafd5b70f35d311cb/lib/avro/data_file.php#L451) this property has to be public
|
Do you suggest to deprecate this fork then? Or how would you see the transition? |
Collaborator
Author
|
@mente I would first phase out this dependency in upstream packages (schema registry, avro serde) with a new major version release that doesn't guarantee BC. Then I guess some Flix internal repositories would have to remove explicit dependencies on this fork from composer.json files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flix-tech/avro-serde-php#53
@mente we have been forking this library previously because the researchgate repository was not very responsive in adding required changes. But it seems that most of the community patches target the parent repository. It may be a good idea to revert towards the researchgate repository instead of our fork. What do you think?