Add logicalType/decimal support to read bytes#20
Conversation
|
Hi @tPl0ch just pinging if there is any insight you have on this. Thanks again for maintaining this! |
|
Thank you @ralphschindler for implementing this feature. We had the same need and will use your PR. |
|
@stefankleff , could you test this on the dev-master branch after the merge before I release a new version? I currently don't have the necessary confidence in the testing / CI of this project? |
|
@tPl0ch Thanks for merging and your overall effort! |
|
Apologies for being silent, I am unsure why I didn't get notifications of communications on updates to this issue. In any case, thank you for merging! I'll be glad to assist in testing future PRs, I would just need a little direction. Thanks again! |
This PR adds support for (at least) reading streams topics that have a schema that includes an Avro
bytetype withlogicalType = "decimal"to be able to decode it into a decimal (instead of returning the bytes in the resulting structure.Outstanding questions:
write_bytes()?Reference for this implementation is here: https://avro.apache.org/docs/1.10.2/spec.html#Decimal
Thanks for your library and assistance!