core: added filesystem abstraction layer#9325
Draft
leonardo-albertovich wants to merge 5 commits intomasterfrom
Draft
core: added filesystem abstraction layer#9325leonardo-albertovich wants to merge 5 commits intomasterfrom
leonardo-albertovich wants to merge 5 commits intomasterfrom
Conversation
added 5 commits
September 2, 2024 16:41
Signed-off-by: leonardo-albertovich <leonardo.alminana@chronosphere.io>
Signed-off-by: leonardo-albertovich <leonardo.alminana@chronosphere.io>
Signed-off-by: leonardo-albertovich <leonardo.alminana@chronosphere.io>
Signed-off-by: leonardo-albertovich <leonardo.alminana@chronosphere.io>
Signed-off-by: leonardo-albertovich <leonardo.alminana@chronosphere.io>
Member
|
@leonardo-albertovich is this one is ready pls remove the draft mode |
Contributor
Author
|
I'd like to get a chance to add the monitoring part before we merge it which I won't be able to work on for about two weeks so I think it'd be better to leave it as a draft for the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a platform agnostic filesystem interface that implements functionality that used to be repeated in multiple plugins.
A platform agnostic change monitoring component based on native facilities (inotify, windows fs change notifications, FSEvent, etc) will be added before this is merged.
This PR does not change any of the existing code in significative ways other than renaming
flb_file_readtoflb_file_read_contents.Note: This PR contains the comoponents introduced by PR 7564 in a way that can be merged immediately with no compromises and another PR will be opened to update
in_tailto use the new abstraction layer.