Repository navigation
record_accessor: raise ConfigError for a non-integer array index - #5596
Merged
Merged
Conversation
A key such as `$.a[x]` or `$['a'][x]` made Integer() raise ArgumentError, so Fluentd stopped with an unexpected error instead of reporting a config error with the file name. Convert it to Fluent::ConfigError like the other syntax errors next to it. Signed-off-by: Lucas Barros <lucasbarros.kam@gmail.com>
Watson1978
added
the
backport to v1.19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #5595
What this PR does / why we need it:
A record_accessor key with a non-integer array index, such as
$.a[x]or$['a'][x], reachedInteger(index_value)and raisedArgumentError. Fluentd stopped with "unexpected error" (or a backtrace on 1.16) instead of a config error.Now both the dot and the bracket parsers raise
Fluent::ConfigError, like the other syntax errors next to them.Before:
After, with the configuration from the issue and
fluentd --dry-run:Tests: added both keys to the two
invalid syntaxdata sets intest/plugin_helper/test_record_accessor.rb. They fail on master withArgumentErrorand pass with this change.Docs Changes:
N/A
Release Note:
record_accessor: report a non-integer array index such as
$.a[x]as a config error.