refactor(rollup): challenges on accepted batches#30
Draft
d1r1 wants to merge 6 commits into
Draft
Conversation
d1r1
commented
Apr 6, 2026
d1r1
commented
Contributor
- allow challenges on Accepted or Preconfirmed batches
- remove preconfirmWindow deadline and storage field
- add maxDepositsPerBatch cap enforced per batch total
- split monolithic deploy into per-contract scripts - enforce nonce==0 for deterministic proxy addrs - add role/config validation before broadcast - add hasRole checks before admin renounce - move config to per-env JSON, ops to operations/ - add MigrateRoles, timelocks, upgrade scripts
- drop oz-upgrades-from annotation on L1FluentBridge - wire UpgradeL1Bridge reference via env vars - simplify bridge e2e tests for live relayer - sync FOUNDRY_OUT and L2_FORGE defaults with forge - rotate testnet operator address and refresh manifests
- prevent permanent L1↔L2 divergence when batches revert - add Queue.pushFront to restore at queue front - track per-batch deposit IDs for reverse-order restore - expose pushSentMessage on L1FluentBridge (onlyRollup) - add regression test with interleaved enqueue scenario
- allow challenges on Accepted or Preconfirmed batches - remove preconfirmWindow deadline and storage field - add maxDepositsPerBatch cap enforced per batch total
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- mirrors prior change letting challenges hit Accepted state - removes preconfirmation as a hard prerequisite for finalize - closes the gap where Accepted batches stalled until challenged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.