This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Android] Speed up the method 'FlutterRenderer.getBitmap' #37342
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pixel order of
ARGB_8888after storage is ABGR on the Java side. Java is big endian and native is little endian, so the order is RGBA on the C++ side.So we can use 'Bitmap.copyPixelsFromBuffer' to do pixel copy, which can avoid the conversion of RGBA to BGRA here.
engine/shell/platform/android/platform_view_android_jni_impl.cc
Lines 354 to 362 in d4101ab
In my local test, the average time consumption of the method FlutterRenderer.getBitmap before optimization is 99.7ms, and it is 66.2ms after optimization.
Pre-launch Checklist
///).