Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@alanwutang11
Copy link
Contributor

@alanwutang11 alanwutang11 commented Dec 2, 2022

implement targetWidth and targetHeight for canvaskit.

fixes: flutter/flutter#34075

for instantiateImageCodec, only support for single frame images. Trying to use a targetWidth and/or targetHeight with an image with multiple frames (like a gif) will give a warning and result in a no-op

In the future, targetWidth and targetHeight re-sizing support will be moved to a web worker to avoid janking the UI

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Dec 2, 2022
@alanwutang11 alanwutang11 marked this pull request as ready for review December 2, 2022 07:51
@skia-gold
Copy link

Gold has detected about 72 new digest(s) on patchset 2.
View them at https://flutter-engine-gold.skia.org/cl/github/38028

Copy link
Contributor

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[web] Support instantiating an image with targetWidth and targetHeight

3 participants