This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[ios_platform_view] more precision when determine if a clip rrect is necessary #38965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyanglaz
force-pushed
the
platform_view_cliprrect_fix
branch
from
d8b5fe9 to
bd92e72
Compare
added 2 commits
January 17, 2023 21:18
jmagman
approved these changes
Jan 18, 2023
hellohuanlin
approved these changes
Jan 18, 2023
| bounding_rect, transformMatrix)) { | ||
| break; | ||
| } | ||
| // TODO(cyanglaz): Find a way to pre-determine if path contains the PlatformView boudning |
Contributor
There was a problem hiding this comment.
this is probably a hard geometry problem. but i bet most clipping actions are just simple shapes like RRect
| {transformed_lower_right_x, transformed_lower_right_y}, | ||
| {transformed_lower_left_x, transformed_lower_left_y}}; | ||
| transformed_rrect.setRectRadii(transformed_clip_rect, corners); | ||
| return transformed_rrect.contains(platformview_boundingrect); |
Contributor
There was a problem hiding this comment.
i assume this contains actually take its radii into consideration (rather than just checking rectangular bounds)?
Contributor
Author
There was a problem hiding this comment.
Yep, it does. the new scenario app test covers it. The new unit test also covered it. I had to use (-1, -1) as the origin for the clipRRect with a 1 radius to avoid clipping the PlatformView at (0, 0) origin.
cyanglaz
added
the
autosubmit
This was referenced Jan 18, 2023
This was referenced Jan 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the clipRRect's bounding rect is used to determine if the clipRRect operation is necessary on PlatformView. (See #37434) This causes a bug when the bounding rect is not clipping the PlatformView but the corner radii are.
This PR uses the whole rrect to determine if the clip operation is necessary.
To prevent similar regression, this PR also removed the similar buggy logic for clipPath. clipPath is not as trival, a TODO is added and I should cycle back to work on clipPath later.
fixes flutter/flutter#118550
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.