Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] turned on validations for all debug builds #45350

Merged
auto-submit merged 5 commits into from
Sep 1, 2023
Merged

[Impeller] turned on validations for all debug builds #45350

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
602d4d6
[Impeller] turned on validations for all debug builds
gaaclarke Aug 31, 2023
ed15378
Build vulkan validation layers with api level 26, and bundle
zanderso Sep 1, 2023
ba3544d
moved the logic to turn on the validation layers to gn
gaaclarke Sep 1, 2023
8e1c91a
added log statement about using validation layers
gaaclarke Sep 1, 2023
27f5515
added log statement
gaaclarke Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion shell/platform/android/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,9 @@ action("android_jar") {
":pom_libflutter",
]

if (enable_vulkan_validation_layers) {
if (enable_vulkan_validation_layers ||
(impeller_enable_vulkan && current_cpu == "arm64" &&
flutter_runtime_mode == "debug")) {
assert(impeller_enable_vulkan)
deps += [ "//third_party/vulkan_validation_layers" ]
Copy link
Copy Markdown
Member

@zanderso zanderso Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between this and //third_party/vulkan-deps/vulkan-validation-layers ?

Copy link
Copy Markdown
Member

@zanderso zanderso Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. They're the same thing https://github.com/flutter/buildroot/blob/master/build/secondary/third_party/vulkan_validation_layers/BUILD.gn.

args += [
Expand Down
10 changes: 9 additions & 1 deletion shell/platform/android/io/flutter/embedding/engine/loader/FlutterLoader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,13 @@ public InitResult call() {
}
}

private static boolean areValidationLayersOnByDefault() {
if (BuildConfig.DEBUG && Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
return Build.SUPPORTED_ABIS[0].equals("arm64-v8a");
}
return false;
}

/**
* Blocks until initialization of the native system has completed.
*
Expand Down Expand Up @@ -324,7 +331,8 @@ public void ensureInitializationComplete(
if (metaData.getBoolean(ENABLE_IMPELLER_META_DATA_KEY, false)) {
shellArgs.add("--enable-impeller");
}
if (metaData.getBoolean(ENABLE_VULKAN_VALIDATION_META_DATA_KEY, false)) {
if (metaData.getBoolean(
ENABLE_VULKAN_VALIDATION_META_DATA_KEY, areValidationLayersOnByDefault())) {
shellArgs.add("--enable-vulkan-validation");
}
String backend = metaData.getString(IMPELLER_BACKEND_META_DATA_KEY);
Expand Down