Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[camera] Fixed stale images in imageStream subscriptions #3344

Merged
mvanbeusekom merged 8 commits into from
Jan 5, 2021
Merged

[camera] Fixed stale images in imageStream subscriptions #3344

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3c02789
Fixed stale images in imageStream subscriptions
danielroek Dec 17, 2020
a4545b1
Implemented feedback
danielroek Dec 17, 2020
c0f8944
Fixed format exception
danielroek Dec 17, 2020
a5227bd
added null-check for imageStreamReader
danielroek Dec 17, 2020
df72d6d
Removed setOnImageAvailableListener from onCancel
danielroek Dec 18, 2020
d4bf016
Merge remote-tracking branch 'origin/bug/stale_images' into bug/stale…
danielroek Dec 18, 2020
db4a245
fixed formatting
danielroek Dec 18, 2020
0819302
Merge remote-tracking branch 'origin/master' into bug/stale_images
danielroek Jan 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/camera/camera/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.6.0+2

Set ImageStreamReader listener to null to prevent stale images when streaming images.

## 0.6.0+1

Updated README to inform users that iOS 10.0+ is needed for use
Expand Down
5 changes: 5 additions & 0 deletions packages/camera/camera/android/src/main/java/io/flutter/plugins/camera/Camera.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,6 +509,11 @@ private void setImageStreamImageAvailableListener(final EventChannel.EventSink i
null);
}

public void stopImageStream() throws CameraAccessException {
imageStreamReader.setOnImageAvailableListener(null, null);
Comment thread
danielroek marked this conversation as resolved.
Outdated
startPreview();
}

private void closeCaptureSession() {
if (cameraCaptureSession != null) {
cameraCaptureSession.close();
Expand Down
2 changes: 1 addition & 1 deletion .../camera/camera/android/src/main/java/io/flutter/plugins/camera/MethodCallHandlerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ public void onMethodCall(@NonNull MethodCall call, @NonNull final Result result)
case "stopImageStream":
{
try {
camera.startPreview();
camera.stopImageStream();
result.success(null);
} catch (Exception e) {
handleException(e, result);
Expand Down
2 changes: 1 addition & 1 deletion packages/camera/camera/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: camera
description: A Flutter plugin for getting information about and controlling the
camera on Android and iOS. Supports previewing the camera feed, capturing images, capturing video,
and streaming image buffers to dart.
version: 0.6.0+1
version: 0.6.0+2
homepage: https://github.com/flutter/plugins/tree/master/packages/camera/camera

dependencies:
Expand Down