This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter] Extract WKWebView implementation into a separate package #4345
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| # Below is a list of people and organizations that have contributed | ||
| # to the Flutter project. Names should be added to the list like so: | ||
| # | ||
| # Name/Organization <email address> | ||
|
|
||
| Google Inc. | ||
| The Chromium Authors | ||
| German Saprykin <saprykin.h@gmail.com> | ||
| Benjamin Sauer <sauer.benjamin@gmail.com> | ||
| larsenthomasj@gmail.com | ||
| Ali Bitek <alibitek@protonmail.ch> | ||
| Pol Batlló <pol.batllo@gmail.com> | ||
| Anatoly Pulyaevskiy | ||
| Hayden Flinner <haydenflinner@gmail.com> | ||
| Stefano Rodriguez <hlsroddy@gmail.com> | ||
| Salvatore Giordano <salvatoregiordanoo@gmail.com> | ||
| Brian Armstrong <brian@flutter.institute> | ||
| Paul DeMarco <paulmdemarco@gmail.com> | ||
| Fabricio Nogueira <feufeu@gmail.com> | ||
| Simon Lightfoot <simon@devangels.london> | ||
| Ashton Thomas <ashton@acrinta.com> | ||
| Thomas Danner <thmsdnnr@gmail.com> | ||
| Diego Velásquez <diego.velasquez.lopez@gmail.com> | ||
| Hajime Nakamura <nkmrhj@gmail.com> | ||
| Tuyển Vũ Xuân <netsoft1985@gmail.com> | ||
| Miguel Ruivo <miguel@miguelruivo.com> | ||
| Sarthak Verma <sarthak@artiosys.com> | ||
| Mike Diarmid <mike@invertase.io> | ||
| Invertase <oss@invertase.io> | ||
| Elliot Hesp <elliot@invertase.io> | ||
| Vince Varga <vince.varga@smaho.com> | ||
| Aawaz Gyawali <awazgyawali@gmail.com> | ||
| EUI Limited <ian.evans3@admiralgroup.co.uk> | ||
| Katarina Sheremet <katarina@sheremet.ch> | ||
| Thomas Stockx <thomas@stockxit.com> | ||
| Sarbagya Dhaubanjar <sarbagyastha@gmail.com> | ||
| Ozkan Eksi <ozeksi@gmail.com> | ||
| Rishab Nayak <rishab@bu.edu> | ||
| ko2ic <ko2ic.dev@gmail.com> | ||
| Jonathan Younger <jonathan@daikini.com> | ||
| Jose Sanchez <josesm82@gmail.com> | ||
| Debkanchan Samadder <debu.samadder@gmail.com> | ||
| Audrius Karosevicius <audrius.karosevicius@gmail.com> | ||
| Lukasz Piliszczuk <lukasz@intheloup.io> | ||
| SoundReply Solutions GmbH <ch@soundreply.com> | ||
| Rafal Wachol <rwachol@gmail.com> | ||
| Pau Picas <pau.picas@gmail.com> | ||
| Christian Weder <chrstian.weder@yapeal.ch> | ||
| Alexandru Tuca <salexandru.tuca@outlook.com> | ||
| Christian Weder <chrstian.weder@yapeal.ch> | ||
| Rhodes Davis Jr. <rody.davis.jr@gmail.com> | ||
| Luigi Agosti <luigi@tengio.com> | ||
| Quentin Le Guennec <quentin@tengio.com> | ||
| Koushik Ravikumar <koushik@tengio.com> | ||
| Nissim Dsilva <nissim@tengio.com> | ||
| Giancarlo Rocha <giancarloiff@gmail.com> | ||
| Ryo Miyake <ryo@miyake.id> | ||
| Théo Champion <contact.theochampion@gmail.com> | ||
| Kazuki Yamaguchi <y.kazuki0614n@gmail.com> | ||
| Eitan Schwartz <eshvartz@gmail.com> | ||
| Chris Rutkowski <chrisrutkowski89@gmail.com> | ||
| Juan Alvarez <juan.alvarez@resideo.com> | ||
| Aleksandr Yurkovskiy <sanekyy@gmail.com> | ||
| Anton Borries <mail@antonborri.es> | ||
| Alex Li <google@alexv525.com> | ||
| Rahul Raj <64.rahulraj@gmail.com> | ||
| Maurits van Beusekom <maurits@baseflow.com> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| ## 0.0.1 | ||
|
Contributor
There was a problem hiding this comment. Nit: Let's use the current flutter_webview version as a starting point. It's kind of weird to have it look like this is a completely new thing.
Contributor
Author
There was a problem hiding this comment. I agree and updated the version to 2.0.13 (same as current webview_flutter package). |
||
|
|
||
| * Extract WKWebView implementation from `webview_flutter`. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| Copyright 2013 The Flutter Authors. All rights reserved. | ||
|
|
||
| Redistribution and use in source and binary forms, with or without modification, | ||
| are permitted provided that the following conditions are met: | ||
|
|
||
| * Redistributions of source code must retain the above copyright | ||
| notice, this list of conditions and the following disclaimer. | ||
| * Redistributions in binary form must reproduce the above | ||
| copyright notice, this list of conditions and the following | ||
| disclaimer in the documentation and/or other materials provided | ||
| with the distribution. | ||
| * Neither the name of Google Inc. nor the names of its | ||
| contributors may be used to endorse or promote products derived | ||
| from this software without specific prior written permission. | ||
|
|
||
| THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND | ||
| ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED | ||
| WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE | ||
| DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR | ||
| ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES | ||
| (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; | ||
| LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON | ||
| ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | ||
| (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS | ||
| SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # webview\_flutter\_wkwebview | ||
|
|
||
| The Apple WKWebView implementation of [`webview_flutter`][1]. | ||
|
|
||
| ## Usage | ||
|
|
||
| This package is [endorsed][2], which means you can simply use `webview_flutter` | ||
| normally. This package will be automatically included in your app when you do. | ||
|
|
||
| [1]: https://pub.dev/packages/webview_flutter | ||
| [2]: https://flutter.dev/docs/development/packages-and-plugins/developing-packages#endorsed-federated-plugin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # This file tracks properties of this Flutter project. | ||
| # Used by Flutter tool to assess capabilities and perform upgrades etc. | ||
| # | ||
| # This file should be version controlled and should not be manually edited. | ||
|
|
||
| version: | ||
| revision: 1e5cb2d87f8542f9fbbd0f22d528823274be0acb | ||
| channel: master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # webview_flutter_example | ||
|
|
||
| Demonstrates how to use the webview_flutter plugin. | ||
|
|
||
| ## Getting Started | ||
|
|
||
| For help getting started with Flutter, view our online | ||
| [documentation](https://flutter.dev/). |
Binary file not shown.
Binary file not shown.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The webview_flutter/webview_flutter changes should be reverted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.