Fix compiling of marketing site after events page change#13500
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request cleans up a duplicate declaration of the now variable, formats the cutoff variable assignment, and fixes a bug by replacing the undefined today variable with cutoff in the event filtering logic. There are no review comments, so I have no feedback to provide.
Collaborator
|
Staged preview of the updated docs.flutter.dev site (updated for commit 1022eac): https://flutter-docs-prod--docs-pr13500-fix-events-page-compil-owkyc73s.web.app |
Collaborator
|
Staged preview of the updated flutter.dev site (updated for commit 1022eac): https://flutter-dev-230821--www-pr13500-fix-events-page-compil-2z2ws492.web.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 8b1525f failing to run and deploy due to inconsistencies after applying the suggested changes through the GitHub UI.