chore(unitTest): rename to execute tests with defaults values#267
Open
paologallinaharbur wants to merge 1 commit intofluxcd-community:mainfrom
Open
chore(unitTest): rename to execute tests with defaults values#267paologallinaharbur wants to merge 1 commit intofluxcd-community:mainfrom
paologallinaharbur wants to merge 1 commit intofluxcd-community:mainfrom
Conversation
Signed-off-by: Paolo Gallina <paologallina1992@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
By convention the unit test file should have the _test
Not having it causes contributors to missing those file when running "helm unittest"
Special notes for your reviewer:
Let me know whether I need to bump the chart version, since I am modifying only the tests file names I am not sure
Checklist
make reviewable