feat(flux2): add flag for optionally disabling pre-install checks#269
Open
arturshadnik wants to merge 1 commit intofluxcd-community:mainfrom
Open
feat(flux2): add flag for optionally disabling pre-install checks#269arturshadnik wants to merge 1 commit intofluxcd-community:mainfrom
arturshadnik wants to merge 1 commit intofluxcd-community:mainfrom
Conversation
Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com> docs: update artifacthub.io/changes Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
arturshadnik
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a
cli.createfield, and updates the pre-install job and SA templates to be rendered conditionally.The
flux checkpreflight check hardcodes a minimum k8s version. This makes it impossible to install the helm chart on a cluster running an unsupported k8s version.The Flux Installation docs say that Flux may work on older versions, but no support will be provided. Given this, the chart is in my opinion too restrictive. This change is backwards compatible (the value defaults to
true) but allows the helm chart to be used with older version of Kubernetes.Which issue this PR fixes
Special notes for your reviewer:
Checklist
make reviewable