Building a GTK app with 11.0.1

[GaryElshaw]

All of the various Transmission clients are compiling fine with the exception of GTK. Any help would be appreciated.

[vitaut]

As the error says, mixing character (code unit) types is disallowed in {fmt}. In this case the format string is a char string and action_name is a Glib::ustring which uses a different code unit type. To fix this you'll need provide conversion from one to the other or a formatter that does the conversion.

[GaryElshaw]

Is there a change i can report back to the team for future reference? All previous versions of fmt have been working fine.

[vitaut]

Reopening to investigate further since it worked in an earlier version. Could you provide a repro?

[vitaut]

I managed to repro the issue: https://www.godbolt.org/z/cqdMPn6aP. The problem is that ustring is incorrectly detected as as std::string.

[Coeur]

Testing commit by commit, the build regression came exactly with 800a0bb by Viktor Zverovich on January 4, 2024.

[GaryElshaw]

@vitaut Is this a change you think Transmission needs to address, or something for fmt to look at?

[vitaut]

It's a bug in {fmt}, we shouldn't treat ustring as std::string. I'll submit a fix.

[GaryElshaw]

Thank you!

[vitaut]

Should be fixed in 7a8b54a. Could you verify it?

[Coeur]

Verified successful. Thank you. Sorry for only pointing this out after the 11.0.1 release instead of before.