"Use" fwrite result (workaround for warn_unused_result)#2187
Closed
BillyDonahue wants to merge 1 commit into
Closed
"Use" fwrite result (workaround for warn_unused_result)#2187BillyDonahue wants to merge 1 commit into
fwrite result (workaround for warn_unused_result)#2187BillyDonahue wants to merge 1 commit into
Conversation
BillyDonahue
force-pushed
the
ignore_fwrite
branch
from
f7dffa7 to
1973424
Compare
BillyDonahue
force-pushed
the
ignore_fwrite
branch
from
1973424 to
699746b
Compare
vitaut
requested changes
Mar 26, 2021
Comment on lines
158
to
161
| // Don't use fwrite_fully because the latter may throw. | ||
| (void)std::fwrite(full_message.data(), full_message.size(), 1, stderr); | ||
| if (std::fwrite(full_message.data(), full_message.size(), 1, stderr)) { | ||
| ; | ||
| } | ||
| std::fputc('\n', stderr); |
Contributor
There was a problem hiding this comment.
I think we shouldn't be trying to write \n if an error occurs which will also solve the warning:
if (std::fwrite(full_message.data(), full_message.size(), 1, stderr) > 0)
std::fputc('\n', stderr);
Contributor
|
Merged with a small tweak. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2185