Reduce filesize of the tests on MinGW#2995
Merged
Merged
Conversation
vitaut
requested changes
Jul 22, 2022
vitaut
left a comment
vitaut
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR. LGMT with one minor suggestion inline.
This patch removes the workaround applied here 1acfd07. MinGW is not tested on Appveyor anymore.
dimztimz
force-pushed
the
filesize-tests-mingw
branch
from
e3b665e to
0bb7589
Compare
vitaut
approved these changes
Jul 23, 2022
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch removes the workaround applied here 1acfd07. MinGW is not tested on Appveyor anymore. If its added in the future it should be added in Github Actions.