Closed
Conversation
vitaut
reviewed
Nov 30, 2022
Comment on lines
+2715
to
+2716
| handler_.on_text(from, to); | ||
| return; |
Contributor
There was a problem hiding this comment.
These and similar changes elsewhere look unnecessary, please revert.
Author
There was a problem hiding this comment.
I commented on the #3204 reasons for this change and 2 more below.
Contributor
There was a problem hiding this comment.
Thanks for providing more context but I still don't see reasons for changing this. Let's revert. The other changes seem fine.
vitaut
requested changes
Nov 30, 2022
vitaut
left a comment
vitaut
left a comment
Contributor
There was a problem hiding this comment.
Mostly looks good but I don't think we need to change parsing logic. Those returns are perfectly valid code and make the logic a bit more readable.
Contributor
|
Partly merged in b0c8263, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3204 – issues reported by Klocwork