Add 2 more constexprs to fix compile error#4065
Merged
vitaut merged 2 commits intofmtlib:masterfrom Jul 13, 2024
Merged
Conversation
vitaut
requested changes
Jul 11, 2024
Contributor
vitaut
left a comment
vitaut
left a comment
There was a problem hiding this comment.
LGTM but please apply clang-format.
Contributor
Author
|
done |
vitaut
approved these changes
Jul 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example code where this fails:
https://compiler-explorer.com/z/31d3bjxer
With my branch this code succeeds just fine (the compilation error is on purpose, this is
catimplemented as a compile error:https://compiler-explorer.com/z/EzEY6Tse9