Change std::copy to detail::copy in chrono to fix MSVC 19.41.34120 compile errors#4132
Merged
vitaut merged 1 commit intofmtlib:masterfrom Aug 28, 2024
Merged
Conversation
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows the same rationale as commit 6e462b8 to replace
std::copyusage with the librarydetail::copy. Without this, latest MSVC versions will fail to compile when using chrono types.Compile result before changing to
detail::copy:https://www.godbolt.org/z/G5MGeWva6
Compile result after:
https://www.godbolt.org/z/vYex485oz