Conform std::iterator_traits<fmt::appender> to [iterator.traits]/1#4185
Merged
vitaut merged 6 commits intofmtlib:masterfrom Oct 3, 2024
Merged
Conform std::iterator_traits<fmt::appender> to [iterator.traits]/1#4185vitaut merged 6 commits intofmtlib:masterfrom
std::iterator_traits<fmt::appender> to [iterator.traits]/1#4185vitaut merged 6 commits intofmtlib:masterfrom
Conversation
> In addition, the types > ```c++ > iterator_traits<I>::pointer > iterator_traits<I>::reference > ``` > shall be defined as the iterator’s pointer and reference types; that is, for an iterator object `a` of class type, the same type as `decltype(a.operator->())` and `decltype(*a)`, respectively. The type `iterator_traits<I>::pointer` shall be void for an iterator of class type `I` that does not support `operator->`. Additionally, in the case of an output iterator, the types > ```c++ > iterator_traits<I>::value_type > iterator_traits<I>::difference_type > iterator_traits<I>::reference > ``` > may be defined as `void`.
Contributor
Author
|
Some C++20 tests that my naive local build didn't enable EDIT: Not exactly. The issue here was that I forgot the " |
The warning suppression just triggers another warning on a different compiler. Declare defeat. This reverts commit 1accf6c.
Contributor
Author
|
Ok, this now compiles |
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removes the unnecessary member types from
basic_appender.