Changing type of data_ to size_t to avoid compilation errors#4200
Merged
vitaut merged 6 commits intofmtlib:masterfrom Oct 19, 2024
Merged
Changing type of data_ to size_t to avoid compilation errors#4200vitaut merged 6 commits intofmtlib:masterfrom
vitaut merged 6 commits intofmtlib:masterfrom
Conversation
when FMT_PEDANTIC && FMT_WERROR options are enabled """ error: useless cast to type 'class fmt::v10::basic_format_args<fmt::v10::basic_format_context<fmt::v10::appender, char> >' [-Werror=useless-cast] 1449 | basic_format_args<buffer_context<char>>(args)); """
cross compiling for win32 application using MXE environment because long unsigned int != size_t (aka long long unsigned int)
1. If lib is cross-compiled for win32 using MXE environment it cause compilation error -Wconversion on line 730 as sizeof(unsigned long) = 4 and sizeof(size_t) = 8 2. When lib is compiled on Unix like compiler generate error -Wuseless-cast if static_cast is used to fix issue in 1 Futher if size_t is not concrete type then, type data_ can be changed to uint64_t or uint32_t because those have same sizes across all platforms
Contributor
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compilation error -Wconversion on line 730 as sizeof(unsigned long)
= 4 and sizeof(size_t) = 8
-Wuseless-cast if static_cast is used to fix issue in 1