Allow getting size of dynamic format arg store#4270
Merged
vitaut merged 1 commit intofmtlib:masterfrom Dec 19, 2024
hannes-harnisch:master
Merged
Allow getting size of dynamic format arg store#4270vitaut merged 1 commit intofmtlib:masterfrom hannes-harnisch:master
vitaut merged 1 commit intofmtlib:masterfrom
hannes-harnisch:master
Conversation
Contributor
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting the size of the dynamic format arg store is useful if you use that class to dynamically pass around sets of format arguments and want to perform additional verification.
In my case, I am using it to check whether a message, that I'm applying the format args to, has the correct amount of placeholders and currently I have to track the arg count separately, even though that information is already present in the
fmt::dynamic_format_arg_store.