Improve xchar support for std::bitset formatter and fix fill copying bug#4286
Merged
vitaut merged 2 commits intofmtlib:masterfrom Jan 3, 2025
Merged
Improve xchar support for std::bitset formatter and fix fill copying bug#4286vitaut merged 2 commits intofmtlib:masterfrom
fill copying bug#4286vitaut merged 2 commits intofmtlib:masterfrom
Conversation
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
Contributor
|
Merged, thanks! |
|
It looks like this commit has broken other behaviour - the following code now segfaults: Stream << fmt::format( "{}", fmt::styled( Line, Style ) ) << "\n";will try and get more details and add an issue - I suggest reverting this for now as it breaks consistently across our entire codebase in code used in our test reporting. |
|
to be more precise here: |
Contributor
Author
|
@ja11sop |
|
Please see #4289 - yes I can see those tests must have passed since the PR was merged but I am not sure they quite match the simple case shown in the linked issue. I admit that it seems odd this PR affected things but reviewing the stack trace and looking at the code tells me the backend for fmt is not trivial, plus without this PR we have no issue, with the PR we do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4285
Improve
xcharsupport forstd::bitsetformatter and fix a bug when copying thefillfrombasic_specs.