Add parameter to the fallback to_sys function#4301
Closed
breyerml wants to merge 1 commit intofmtlib:masterfrom
Closed
Add parameter to the fallback to_sys function#4301breyerml wants to merge 1 commit intofmtlib:masterfrom
breyerml wants to merge 1 commit intofmtlib:masterfrom
Conversation
vitaut
requested changes
Jan 9, 2025
Contributor
vitaut
left a comment
vitaut
left a comment
There was a problem hiding this comment.
Thanks for the PR! It looks good but please apply clang-format.
Contributor
|
Merged with a minor tweak in bfbdc2b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add parameter to the fallback to_sys function. Fixes issue #4297.