Add double and float support to scan functionality#4473
Closed
way4sahil wants to merge 4 commits intofmtlib:masterfrom
Closed
Add double and float support to scan functionality#4473way4sahil wants to merge 4 commits intofmtlib:masterfrom
way4sahil wants to merge 4 commits intofmtlib:masterfrom
Conversation
- Add double_type and float_type to scan_type enum - Add double* and float* pointers to scan_arg union - Add constructors for double and float scan arguments - Add switch cases for double and float types in visit() - Implement read() functions for floating-point parsing This resolves the TODO comment 'more types' in scan.h by adding support for the two most commonly needed floating-point types. Verified: All tests pass (21/21 tests passed, 0 failed).
vitaut
requested changes
Jun 19, 2025
Contributor
vitaut
left a comment
vitaut
left a comment
There was a problem hiding this comment.
Thanks for the PR. This is mostly a proof of concept largely superseded by scnlib but we can merge it in. Please fix formatting per inline comment.
vitaut
requested changes
Jun 20, 2025
Contributor
vitaut
left a comment
vitaut
left a comment
There was a problem hiding this comment.
The formatting (indent) is still wrong.
Contributor
|
Merged with minor tweaks in a5dccff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves the TODO comment 'more types' in scan.h by adding support for the two most commonly needed floating-point types.
Verified: All tests pass (21/21 tests passed, 0 failed).