Fix Ruby 3.0 kwargs failures#523
Merged
geemus merged 1 commit intofog:masterfrom May 12, 2021
Merged
Conversation
Closed
This makes `bundle exec rake test:storage` pass for both Ruby 2.7.2 and 3.0.0. ``` TestStorageRequests test_directories_destroy PASS (2.16s) test_directories_put PASS (0.71s) test_put_object_predefined_acl PASS (1.51s) test_delete_object PASS (1.73s) test_directory_files PASS (1.80s) test_list_object_acl PASS (1.46s) test_directory_public_url PASS (0.84s) test_put_object_contradictory_content_type PASS (1.61s) test_object_metadata PASS (1.65s) test_files_public_url PASS (1.75s) test_copy_object_predefined_acl PASS (8.68s) test_files_get PASS (2.04s) test_list_buckets PASS (1.49s) test_files_destroy PASS (2.29s) test_files_get_https_url PASS (1.10s) test_put_bucket_acl PASS (1.39s) test_put_object_nil PASS (0.67s) test_directories_put_invalid_predefined_acl PASS (0.17s) test_delete_bucket PASS (1.27s) test_get_object PASS (1.83s) test_put_object_paperclip PASS (2.48s) test_get_bucket PASS (4.79s) test_files_all PASS (1.70s) test_get_bucket_acl PASS (1.51s) test_get_object_https_url PASS (1.57s) test_put_object_invalid_predefined_acl PASS (0.77s) test_files_set_body_file PASS (2.73s) test_files_copy PASS (2.73s) test_list_bucket_acl PASS (1.51s) test_get_object_http_url PASS (1.59s) test_put_object_url PASS (0.74s) test_put_bucket PASS (1.56s) test_files_create_invalid_predefined_acl PASS (1.71s) test_put_object_string PASS (1.64s) test_files_set_body_string PASS (2.77s) test_files_create_predefined_acl PASS (1.56s) test_files_create_string PASS (1.73s) test_directories_get PASS (1.00s) test_directories_put_predefined_acl PASS (0.75s) test_copy_object PASS (1.95s) test_files_create_file PASS (1.91s) test_put_bucket_predefined_acl PASS (0.73s) test_files_metadata PASS (7.90s) test_get_object_acl PASS (1.64s) test_put_bucket_invalid_predefined_acl PASS (0.23s) test_directories_all PASS (2.29s) test_list_objects PASS (1.58s) test_put_object_file PASS (1.71s) test_put_object_acl PASS (1.74s) test_files_each PASS (1.76s) test_files_get_https_url_whitespace PASS (0.80s) Finished in 95.19968s 51 tests, 62 assertions, 0 failures, 0 errors, 0 skips ```
geemus
approved these changes
May 12, 2021
Member
|
Looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
bundle exec rake test:storagepass for both Ruby 2.7.2 and3.0.0.