feat(googlefonts): add no_oblique_bit check#667
Open
felipesanches wants to merge 4 commits intofonttools:mainfrom
Open
feat(googlefonts): add no_oblique_bit check#667felipesanches wants to merge 4 commits intofonttools:mainfrom
felipesanches wants to merge 4 commits intofonttools:mainfrom
Conversation
Adds a check that FAILs when the OS/2 fsSelection OBLIQUE bit (bit 9) is set. Google Fonts does not want this bit enabled. Closes fonttools#238 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add test that verifies the check fails when the OBLIQUE bit (bit 9) is set in OS/2 fsSelection. The test loads Mada-Regular, sets the OBLIQUE bit via raw OS/2 table byte manipulation, and asserts the "oblique-bit-set" failure is produced. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
|
Please add a hotfix function which turns off this bit. |
…check Add a hotfix function that clears the OBLIQUE bit (bit 9) from OS/2 fsSelection, following the same pattern as the use_typo_metrics hotfix. Also add a test verifying the hotfix works correctly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
Done! Added a hotfix function Also added a test ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
googlefonts/no_oblique_bitthat FAILs when OS/2 fsSelection OBLIQUE bit is setCloses #238
Test plan
cargo test --workspacepasses (0 failures)cargo clippy --all -- -D warningscleancargo fmt --all -- --checkclean🤖 Generated with Claude Code