Repository navigation
[cffLib] read CFF font names as latin-1, like the compiler writes them - #4253
Merged
Merged
Conversation
anthrotype
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A CFF font whose name has a non-ASCII byte can be saved but not read back.
CFFFontSet.decompile decodes the Name INDEX with tostr(s), i.e. ASCII, while IndexCompiler writes str items with tobytes(item, encoding="latin1"), and the String INDEX is already read as latin1 (IndexedStrings). So
saves fine and then fails with "UnicodeDecodeError: 'ascii' codec can't decode byte 0xe9", which makes the whole CFF table unreadable.
The names are now decoded as latin1, matching the compiler. Added a test that saves a font with a non-ASCII name and reads it back.