Skip to content

Update CMakeLists.txt fix include path#165

Merged
foonathan merged 1 commit intofoonathan:mainfrom
jiayuehua:patch-1
Jun 18, 2023
Merged

Update CMakeLists.txt fix include path#165
foonathan merged 1 commit intofoonathan:mainfrom
jiayuehua:patch-1

Conversation

@jiayuehua
Copy link
Contributor

@jiayuehua jiayuehua commented Jun 9, 2023

No description provided.

@jiayuehua
Copy link
Contributor Author

jiayuehua commented Jun 9, 2023

microsoft/vcpkg#31905

@jiayuehua
Copy link
Contributor Author

jiayuehua commented Jun 15, 2023

@foonathan

@foonathan
Copy link
Owner

foonathan commented Jun 15, 2023

Can you elaborate on the consequences and reason for this change?

@jiayuehua
Copy link
Contributor Author

jiayuehua commented Jun 15, 2023 •
edited
Loading

If installed to include/foonathan, then client code must use
include "foonathan/foonathan/memory…" other than include "foonathan/memory".

after this fix, some other vcpkg port that already rely on your memory lib can work again.

also from microsoft/vcpkg#30212

CMake Error in src/cpp/CMakeLists.txt:
  Imported target "foonathan_memory" includes non-existent path

    "D:/installed/x86-windows/include/foonathan_memory"

  in its INTERFACE_INCLUDE_DIRECTORIES.

@foonathan foonathan merged commit f7afdd1 into foonathan:main Jun 18, 2023
@foonathan
Copy link
Owner

foonathan commented Jun 18, 2023

Okay, that's fair. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jiayuehua @foonathan