MS-NEGOEX Phase 3 Implementation#2213
Draft
ThatTotallyRealMyth wants to merge 7 commits into
Draft
Conversation
…engo helper functions
Added the getNegoExMessages() function to both the init and response classes
Raise NotImplementedError in smb3.py if NEGOEX is selected instead of parsing as NTLM messages
Raise LDAPSessionError for unsupported NEGOEX/PKU2U authentication instead of parsing it as a type2 NTLM message. Unsure as to using LDAPSessionError or using the NotImplementedError like in smb3.py
Contributor
Author
|
Hey @anadrianmanrique you mentioned smb and ldap for updating to handle NEGOEX but you never mentioned DCERPC. Should I add the same the same thing in kerberosv5.py, here ################################################################################
# DCE RPC Helpers
################################################################################
def getKerberosType3(cipher, sessionKey, auth_data):
negTokenResp = SPNEGO_NegTokenResp(auth_data)Or should I leave that out? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Hey, opening this PR to begin tracking work on the phase 3 of the ms-negoex implementation. So far the helper functions have been implemented, the proposed testcases from PR1/2 have been integrated and they all pass:
┌──(kali㉿kali)-[~/personalprojects/impacket-contributions] └─$ python3 test_spnego_negoex.py -v test_malformed_negoex_payload_raises_clear_error_when_selected (__main__.SPNEGONegoExTests.test_malformed_negoex_payload_raises_clear_error_when_selected) ... ok test_neg_token_init_detects_negoex_offered (__main__.SPNEGONegoExTests.test_neg_token_init_detects_negoex_offered) ... ok test_neg_token_init_does_not_parse_ntlm_as_negoex (__main__.SPNEGONegoExTests.test_neg_token_init_does_not_parse_ntlm_as_negoex) ... ok test_neg_token_init_parses_negoex_mech_token_messages (__main__.SPNEGONegoExTests.test_neg_token_init_parses_negoex_mech_token_messages) ... ok test_neg_token_resp_detects_negoex_selected (__main__.SPNEGONegoExTests.test_neg_token_resp_detects_negoex_selected) ... ok test_neg_token_resp_does_not_parse_ntlm_response_as_negoex (__main__.SPNEGONegoExTests.test_neg_token_resp_does_not_parse_ntlm_response_as_negoex) ... ok test_neg_token_resp_parses_negoex_response_token_messages (__main__.SPNEGONegoExTests.test_neg_token_resp_parses_negoex_response_token_messages) ... ok ---------------------------------------------------------------------- Ran 7 tests in 0.002s OKI wasnt sure how to handle as I noticed in the provided test cases you have a function called getNegoExMessages() but you didnt mention it in #2195 so I assumed that since you gave it to me in a proposed testcase that you wanted it. Happy to remove it as well if it was not intended