tds: fix binary and char column values displaying as Python bytes repr#2214
Open
n3rada wants to merge 2 commits into
Open
tds: fix binary and char column values displaying as Python bytes repr#2214n3rada wants to merge 2 commits into
n3rada wants to merge 2 commits into
Conversation
anadrianmanrique
added
the
in review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseRow()stored rawbytesfor three column types, causing values to render with theb'...'Python representation in SQL output (see #2043).TDS_BIGVARBINTYPE/TDS_BIGBINARYTYPE:binascii.b2a_hex()returnsbytes; added.decode("ascii")so the hex string prints cleanly.TDS_IMAGETYPE: same issue, same fix.TDS_BIGCHARTYPE/TDS_TEXTTYPE: raw byte slices stored without decoding; now decoded aslatin-1(withutf-8fallback), matching howTDS_BIGVARCHRTYPEalready handles character data.Verified against a live SQL Server instance with
enum_users(sp_helpuser), which exercises bothTDS_BIGCHARTYPE(UserID) andTDS_BIGVARBINTYPE(SID).