Skip to content

WIP: Add basic support for openapi#120

Merged
fotinakis merged 30 commits intofotinakis:masterfrom
gabrieltaylor:gtr/openapi-3
Sep 26, 2019
Merged

WIP: Add basic support for openapi#120
fotinakis merged 30 commits intofotinakis:masterfrom
gabrieltaylor:gtr/openapi-3

Conversation

@gabrieltaylor
Copy link
Contributor

@gabrieltaylor gabrieltaylor commented Oct 8, 2018

Adds support for PetStore OpenAPI 3 example.

Support for OpenAPI 3 is not feature complete.

TODO

  • Add support for callbacks ✅
  • Add support for links example
  • Add support for examples example
  • Add support for authentication schemes ✅
  • Expand tests

@gabrieltaylor gabrieltaylor mentioned this pull request Oct 8, 2018
The version param allows us to handle references differently depending
on the version of the spec.
@gabrieltaylor
Copy link
Contributor Author

@fotinakis I think that this is ready for your review. Looking forward to hearing your thoughts.

@haseleyi
Copy link

Would love to see this feature supported :)

@auscaster
Copy link

It seems like a lot of work has gone into this, any chance of getting it merged?

@pascalbetz
Copy link

Or any feedback on why it has not been merged so far?
Is there something we can do?
What is missing? What could/should be done differently?

We use swagger-blocks and this PR contains features that would be useful to us (the gem is already useful to us. Even without this PR. Many thanks).

@fotinakis fotinakis self-requested a review September 25, 2019 16:54
Copy link
Owner

@fotinakis fotinakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks for putting this together. I don't have much time to maintain this gem anymore, but can merge and release this. Should this be a major version bump or is it backwards compatible?

@gabrieltaylor
Copy link
Contributor Author

@fotinakis It should be backwards compatible as the v2 tests still pass, however, given the number of changes and the fact that it adds support for a major version change of Open API, a major version bump of swagger-blocks might be safer.

@fotinakis fotinakis merged commit fc1adfb into fotinakis:master Sep 26, 2019
@fotinakis
Copy link
Owner

Thanks for the great work here.

Released as a major bump to gem version 3.0.0 — if there bugs we can fix them and release there.

@auscaster
Copy link

auscaster commented Sep 27, 2019 via email

@PhilippeChab
Copy link

The README should be updated to reflect this merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants