WIP: Add basic support for openapi#120
Conversation
6f48b5d to
b01b64a
Compare
The version param allows us to handle references differently depending on the version of the spec.
b01b64a to
68bf419
Compare
|
@fotinakis I think that this is ready for your review. Looking forward to hearing your thoughts. |
709ac12 to
b9c3fca
Compare
|
Would love to see this feature supported :) |
Gtr/openapi 3
|
It seems like a lot of work has gone into this, any chance of getting it merged? |
|
Or any feedback on why it has not been merged so far? We use swagger-blocks and this PR contains features that would be useful to us (the gem is already useful to us. Even without this PR. Many thanks). |
fotinakis
left a comment
There was a problem hiding this comment.
LGTM 👍
Thanks for putting this together. I don't have much time to maintain this gem anymore, but can merge and release this. Should this be a major version bump or is it backwards compatible?
|
@fotinakis It should be backwards compatible as the v2 tests still pass, however, given the number of changes and the fact that it adds support for a major version change of Open API, a major version bump of swagger-blocks might be safer. |
|
Thanks for the great work here. Released as a major bump to gem version |
|
Nice one Mike! Thanks for merging :)
…On Thu, 26 Sep 2019 at 19:56, Mike Fotinakis ***@***.***> wrote:
Thanks for the great work here.
Released as a major bump to gem version 3.0.0 — if there bugs we can fix
them and release there.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#120?email_source=notifications&email_token=AAAYUDBPTBSRSB575MF6UJDQLTZTBA5CNFSM4FZUVF7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7WN7IQ#issuecomment-535617442>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAYUDFSNJ7HDSHPBFCXIWTQLTZTBANCNFSM4FZUVF7A>
.
|
|
The README should be updated to reflect this merge. |
Adds support for PetStore OpenAPI 3 example.
Support for OpenAPI 3 is not feature complete.
TODO