fix: correct RedeemRequest event param from assets to shares#822
Merged
zerosnacks merged 2 commits intofoundry-rs:masterfrom Feb 23, 2026
Merged
fix: correct RedeemRequest event param from assets to shares#822zerosnacks merged 2 commits intofoundry-rs:masterfrom
zerosnacks merged 2 commits intofoundry-rs:masterfrom
Conversation
davidjsonn
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg and
zerosnacks
as code owners
zerosnacks
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the RedeemRequest event in IERC7540Redeem had
assetsas the last param, but per EIP-7540 spec it should beshares. redeem operates on shares, deposit operates on assets - the event was copy-pasted wrong.ref: https://eips.ethereum.org/EIPS/eip-7540#events