Clarify requestRedeem docs#831
Merged
zerosnacks merged 1 commit intofoundry-rs:masterfrom Mar 13, 2026
Merged
Conversation
tn0vak
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg and
zerosnacks
as code owners
zerosnacks
approved these changes
Mar 13, 2026
Member
zerosnacks
left a comment
zerosnacks
left a comment
There was a problem hiding this comment.
In line with spec: https://github.com/ethereum/ERCs/blob/master/ERCS/erc-7540.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the
IERC7540.requestRedeemcomments to match the actual owner-based flow.The current wording says control is taken from
sender, but the function signature and parameter docs are centered onowner, and the approval model also allows either ERC-20 approval over the owner's shares or operator approval. That mismatch can mislead integrators reading the interface.This is a comment-only change with no ABI, logic, or behavior changes. It simply makes the redeem-side docs consistent with the API semantics and with the already-clarified deposit-side wording.