Conversation
bf9159d to
4ebe406
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
==========================================
- Coverage 55.79% 0.00% -55.80%
==========================================
Files 4 4
Lines 371 396 +25
==========================================
- Hits 207 0 -207
- Misses 164 396 +232
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors dissect.regf by updating file paths in tests, revising packaging metadata, and refactoring registry hive parsing. Key changes include:
- Adjusting the file path used in the system hive fixture.
- Revising the pyproject.toml license configuration and ruff version.
- Refactoring examples/walkhive.py and the internal C structure definitions in dissect/regf/c_regf.py.
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/conftest.py | Updated SYSTEM file path in the system_hive fixture. |
| tests/_docs/conf.py | Added project configuration for Sphinx documentation. |
| pyproject.toml | Revised license settings, updated ruff required version, and removed obsolete setuptools block. |
| examples/walkhive.py | Replaced file I/O with pathlib and refactored registry hive iteration. |
| dissect/regf/c_regf.py | Refactored internal C structure definitions for registry hive parsing. |
Files not reviewed (1)
- tox.ini: Language not supported
Comments suppressed due to low confidence (3)
pyproject.toml:94
- Ensure that the removal of the [tool.setuptools] block is deliberate, and that all necessary packaging metadata is properly configured in its absence.
-[tool.setuptools]
examples/walkhive.py:16
- [nitpick] The use of 'cell.cell' is ambiguous; consider renaming the property to a more descriptive name (e.g. 'data' or 'value') for improved clarity.
print(hex(offset), "+" if allocated else "-", cell.name, cell.cell)
tests/conftest.py:24
- Please verify that changing the file path from "data/SYSTEM.gz" to "_data/SYSTEM.gz" is intentional, as it may affect file lookup.
yield from open_file_gz("_data/SYSTEM.gz")
There was a problem hiding this comment.
Sidenote: Currently, dissect.target (regutil.py) is not compatible anymore. We should be aware of this before merging this in.
Edit: created an issue in dissect.target for tracking (fox-it/dissect.target#1130)
Co-authored-by: Stefan de Reuver <9864602+Horofic@users.noreply.github.com>
Co-authored-by: Stefan de Reuver <9864602+Horofic@users.noreply.github.com>
Closes #31